Vosim & al.

[Toltekradiation]

Great to hear this !

do not hesitate to report any wish for improvement.

[Xavier]

Thanks again Patrice for this new algos.
They really add something to the sound possibilities of the preenfm.
And as they are separate new algos, there's not reason not to include them

I finaly have a PR, can you take a look ?
https://github.com/Ixox/preenfm3/pull/47/

Also, let me know what you think of the commit i added on top yours.
I don't think index should be 0 when we sync. Index should correspond to the phase of the master osc. No ?
Don't hear any obvious change in most presets, but i think that could be more "hearable" when waveform are smaller.

Please confirm the changes :
. 4 New vosim (synced windowed modulation) algos
. New midi CC to control paraphonic filter (FX2)
. small adjustment to Filter2 "BODE"
Anything else i miss ?

Can you explain you change in Osc.h (i added a commment in the PR)..
I don't understand.

Thanks 

[Toltekradiation]

Hello Xavier,
i answered about Osc.h in the PR : it's about a small cpu optimization..

About the phase reset, yes why not using the master osc phase, it should sound a bit better, thanks !

Another small change :
i removed the bias in the sigma filter as it don't bring anything significant and can possibly cause click
https://github.com/Ixox/preenfm3/pull/47/files#r1527499583

[Xavier]

Hello Xavier,
i answered about Osc.h in the PR : it's about a small cpu optimization..

I thought there were a problem.
I looked again and it looks good. Thanks 

[Xavier]

OK i clean up a little as localEnv were not used anymore in getNextBlockWithFeedbackAndEnveloppe.
Let me know if it's OK for you.
If yes can you "approve" the PR. I'll then know it's good for you.

Thanks

[Toltekradiation]

Just tried the new master on my preenfm3, works fine !

[Xavier]

Thanks.
I need to add a little documentation somewhere about the new algos..

And will do the preenfm2 version very soon.

[Toltekradiation]

About documentation, i would mention the first part of the Rob Hordijk page about vosim :
https://electro-music.com/nm_classic/015_workshops/Clavia/NordModularWorkshops&Threads/WerkMap/WorkShops/Hordijk1999-2000/VOSIM.html
which describe well what is done for the windowed sync part.


then for each algo, the comment of the voice.ccp should do :

ALG29 :

Osc 1 synced by 3


                     IM3
                    <----
             .---.         .---.
             | 3*|         | 4 |
             '---'         '---'
             |IM1           |IM2
             .---.          .---.
             |*1 |          | 2 |
             '---'          '---'
             |Mix1          |Mix2


ALG30 :

Osc 1 & 2 synced by 3


       
             .---.         .---.
             | 3*|         | 4 |
             '---'         '---'
             |IM1 \IM2 IM3/ |IM4
             .---.          .---.
             |*1 |          |*2 |
             '---'          '---'
             |Mix1          |Mix2


ALG31 :

Osc 1 2 3 synced by 4


       
                    .---.
                    | 4*|
                    '---'
               /IM1 |IM2 \IM3
             .---.  .---.  .---.
             |*1 |  |*2 |  |*3 |
             '---'  '---'  '---'
             |Mix1  |Mix2  | Mix3



ALG32 :

Osc 1 synced by 4


       
                          IM4
                         ---->
             .---.  .---.     .---.
             | 2 |  | 3 |     | 4*|
             '---'  '---'     '---'
             \IM1  |IM2    /IM3
                   .---.
                   |*1 |
                   '---'

[Toltekradiation]

@Xavier,

as i added the latest modifications of the vosim branch to the preenfm2 version, here is a PR to make things slightly easier for you :
https://github.com/Ixox/preenfm2/pull/18

[Xavier]

Thanks a lot.
I think i'll have time to look at it this week-end.

EDITED : i didn't do it.... But i keep that in my radar.