PreenFM > preenfm2 and preenfm3
Some new hacks
Xavier:
Just saw you updated your git README :)
I think the following would be great in the official firmware:
. Glide enhancement: can polyphonic glide work without the matrix ? I still have to look at your change and try it.
. Envelope loop of modulator operators (that's a really good idea)
. Matrix destination : sq1S, sq2S
. Filter improvement if any
I think the rest (matrix source and other destination) could remain in your firmware for user who wants more experimental stuff.
(That's a detail and i should have done that earlier but i added you in the credits)
Toltekradiation:
hello Xavier,
thanks for including some of those experiments !
Glide enhancement :
yes it can work without the matrix destinations, no problem.
That part was rather difficult to get it right, so i made many commit, not always useful, a real mess ::)..
i think it may be easier for you to compare the code of the poly_glide branch in the git repo : https://github.com/Ixox/preenfm2/compare/master...pvig:poly_glide
here is the useful part for that compare :
https://github.com/Ixox/preenfm2/compare/master...pvig:poly_glide#diff-7f2a092c16d9ab622d97afe017b38f8d
https://github.com/Ixox/preenfm2/compare/master...pvig:poly_glide#diff-4ae98bc1ddd5d4d1ae607c4233a91c4e
https://github.com/Ixox/preenfm2/compare/master...pvig:poly_glide#diff-bdae5acaedebc202d4c97571262ff02f
https://github.com/Ixox/preenfm2/compare/master...pvig:poly_glide#diff-c36a9bfd3d7069018e9d7b6d25b4ac2a
https://github.com/Ixox/preenfm2/compare/master...pvig:poly_glide#diff-e619eae6c2e4a1e46bfaa390d6a3c2c1 ( Timbre::preenNoteOn and Timbre::preenNoteOff )
https://github.com/Ixox/preenfm2/compare/master...pvig:poly_glide#diff-20a635e886b1cae7d49946fbf475b0c7
https://github.com/Ixox/preenfm2/compare/master...pvig:poly_glide#diff-b7a6576387d40ded7ccd8c8c7068dbd2
https://github.com/Ixox/preenfm2/compare/master...pvig:poly_glide#diff-8e15a1aecc932efdb4f35098de376256
Envelope loop commit :
https://github.com/pvig/preenfm2/commit/1a7f8c6f2edaed21382d1c998e755ec54dda73d6
https://github.com/pvig/preenfm2/commit/0021fca4ae5baab9607cd666702fb55c80909a60
Starting point of step seq :
https://github.com/pvig/preenfm2/commit/94a2787037655ae9cbc8c41ddf2db738d8da739c
https://github.com/pvig/preenfm2/commit/ddcbe595696c7969c74fc0dc22a1b2ccb2ad964d
https://github.com/pvig/preenfm2/commit/967b781427e8992cff226630a8316a47983c12c7
https://github.com/pvig/preenfm2/commit/8dc6845122dcd3961cc9d5bdbc740469d5420a47
Filters rework :
https://github.com/pvig/preenfm2/commit/2a9cbf7d15708c3df6f3e6471b281dba3aedc5ee
https://github.com/pvig/preenfm2/commit/facfddb7d5c8718a20be94ac28cab9f3ae0181e1
https://github.com/pvig/preenfm2/commit/aaca4c813e5250c83b4c1809204c051135225284
https://github.com/pvig/preenfm2/commit/71c361f8f4adecc20411809583b4b2c059309b5a
https://github.com/pvig/preenfm2/commit/d35b72b50359c898aa734ff3212a949cc1cccca7
https://github.com/pvig/preenfm2/commit/9b18a9533ed3b2698a48c616d3186f2782047dca
https://github.com/pvig/preenfm2/commit/c8c7a1e4e9a75ea53dc03bc4ad2941b2812f7b4c
i'm afraid it's also a lot of messy commits :-X, you would have better copying the code from https://github.com/pvig/preenfm2/blob/env-loop/src/synth/Timbre.cpp
modified parts :
FILTER_ORYX3 updated
FILTER_XOR has become FILTER_ROT
FILTER_TEXTURE1 updated
FILTER_TEXTURE2 updated
FILTER_LPXOR updated
FILTER_LPXOR2 updated
i hope i did not forget something, it's quite a lot of code to check :P
about matrix sources, i would add the rndK source, as it avoid using a lfo for that (and maybe velD, for the fun factor ;) ). it's as you wish.
and thanks for the add in the credits !
cheers !
Patrice
the_duckchild:
great work both of you!
Xavier:
I'm currently comparing/and merging folders with meld.
It's easier than going through all the commits ;)
Xavier:
Hey Patrice, I have a few questions on your changes :
Why did you substract .5 here ?
https://github.com/pvig/preenfm2/blob/env-loop/src/synth/Timbre.cpp#L760
noise[] values should be already between -1.0 and 1.0.
<EDIT>I have the answer about this one</EDIT>
Why did you need matrix setDestination here ?
https://github.com/pvig/preenfm2/blob/env-loop/src/synth/Timbre.cpp#L821
Wasn't the regular matrix calculation working correctly for sq1S and sq2S ?
The glide enhancement is nice but it really modifies the way voices are allocated even for glide = 0. I cannot include it in the firmware.
I'll take the 2 longer glides though ;)
Envelope loop is nice :)
And the Osc.cpp fix (that you already mentionned me) is a nice catch.
Navigation
[0] Message Index
[*] Previous page
Go to full version