[available in v1.08] global fx attempt : REVERB

[Toltekradiation]

I did a pull request with some fix for the parameter value change.

while i'm at it, i found a bug on config save : it freeze the synth on save, i could not get much information on what happening : in debug mode, the error stack is :
Thread #1 [main] 1 [core: 0] (Suspended : Signal : SIGTRAP:Trace/breakpoint trap)   
   HardFault_Handler() at stm32h7xx_it.c:106 0x80351f6   
   <signal handler called>() at 0xffffffe9   
   dir_find() at ff.c:2 482 0x806719a   
   0x0   

[Xavier]

Thanks for the PR.

The error is when you save the config ?
It works here.
Do you have a pfm3/settings.txt file on your SD ?
Can you save preset and mixers without problem ?
the dir_find in the stack is weird.

[Toltekradiation]

yes i can save mixer, default mixer, presets without problem.
I did not have pfm3/settings.txt on the SD,
so i made an empty one to test : freeze on config save
after reading the SD card again, the settings.txt is gone
so i got a working setting.txt from a pfm2, put it to the SD, reboot, save the config again : freeze again, and the settings.txt disappeared..

yes, quite weird.

[Xavier]

The settings file is removed than save again.
https://github.com/Ixox/preenfm3/blob/master/firmware/Src/filesystem/ConfigurationFile.cpp#L90

So i assume it fails when saving after having removed the file.
But i don't know why.

[Xavier]

You can try with windows to copy your all pfm3 directory on your SD card.
Then rename the old one "pfm3.old", and the new one "pfm3".
Just to see if that's not the SD where it tries to save the file.

Or backup your SD card, format it and copy back your files.

Would be interesting to see if that makes any change.

[Toltekradiation]

thanks for the ideas.
i tried but it did not solve the issue, even with deep formatting with the official SD formater.
I will try again tomorrow with a minimal SD card content.

[Toltekradiation]

hmm, this problem is really weird :
i took another SD card, deep formated it, then put the official SD content (pfm3_SD.zip) on it.
With this SD, i could save every kind of files without any problem, ... but not the config 
if i follow the action in debug mode, it crash on line 89 in ConfigurationFile.cpp

well, i can still edit the SETTINGS.TXT by hand, so it's not such a big deal

[Xavier]

2 things i have in mind :
1. Make sure you have correctly merged Menu.h and Menu.cpp files.
2. Clean the project & Rebuild ALL so that you don't have old enum in some object file.

I'll make a firmware binary tomorrow to make sure we use the same.

[Toltekradiation]

Thanks for the support
you found the problem : i have some trouble with the cleaning of my project :
with the latest v0.107 build from github, everything work perfectly.
but with my local sources, even if i clean before building (Project>Clean in STM32CubeIde), i get the issue.

I work currently on a copy of your branch FXGlobalFX-PVig, which i only slightly modified.
Maybe I have a small drift in my project configuration, i will try to find out what's wrong.

Thanks !

[Xavier]

I built a release with the reverb : v1.08
See more details here :
https://github.com/Ixox/preenfm3/releases
Feedbacks are welcome,

[Toltekradiation]

Hello Xavier,
i think there is some bugs.

In the preset recall :
In my version, some values were smoothed on preset change ; that part of the code was called continuously to make it happen.
In your integration, you do call FxBus::paramChanged() once on preset change, so the smoothing code should be removed.
here is my commit about it :
https://github.com/pvig/preenfm3/commit/fa6be48fb8f49bd753005f473e1220ad24f88ff9

About the predelay time, lfo speed values,
i did some stupid code mistakes , so these value change does not work anymore.
here is the commit :
https://github.com/pvig/preenfm3/commit/1ebce476547bbc72352021a21a66d388d906fc7a

While i was at it, i changed the order of some parameters in the reverb pages, i think it does more sense :
https://github.com/pvig/preenfm3/commit/bd56ea39c794f8f8ec84d0795f42096f0f69b2a6

[Xavier]

No problem 
I'll make an other one with your bug fix.
Thanks a lot for the feedback !

Do you think you can get the latest master branch and make a pull request with your bug fix ?
If not i'll integrate myself, no problem.

[Toltekradiation]

ok, pull request done

[Xavier]

Haha... That was quick.
Thanks a lot 

[Xavier]

1.08a is available with those fixes.
Don't worry if you find others , this reverb is a big feature