Reverb dry/wet modification

[Toltekradiation]

Hello,

i'm not totaly satisfied with the way the dry/wet work, sometimes a classic send is just what is needed.

So i propose another way :
- between 0 and 0.5, the dry/wet behave like a send : ie there is no volume loss from the dry signal.
- from 0.5 to 1, the dry fade out, we can hear only reverb signal at 1.

compiled firmware attached if anyone want to test.

@Xavier, i did a PR for that if you want to have a look : it's a very minor code modification.
+ There is also another PR for fixing a nasty bug

[Xavier]

Hi,

Thanks for the PR.
It took me some time to understand how changing 128 by 255 makes what you describe to the reverb volume.
I got it now.
I'll give it a try.

Not sure about the freq<0 bug.
How to reproduce and is it really "nasty" ?

[Toltekradiation]

yes, the bug fix is in the 2nd PR as well, 1st one was done some weeks ago, did not noticed it was in 2nd one..

anyway, it is a nasty bug because it make the pfm3 crash.
it happen if in a patch, a carrier is in OSC_FT_KEYHZ mode, has a frequency of 0, and the fine tune is set to negative.
So when you go in EDIT mode, in TftDisplay::oscilloNewLowerFrequency negative values ​​are calculated => crash.