[available in v1.08] global fx attempt : REVERB

[Toltekradiation]

it has some flaws, i fear ; the reverb saturate too easily (depending on the sound used).
i'm working on this issue, but with not much luck so far.

[matrix12x]

I was coming across the saturation, I just dial down the sends or the instrument levels.

Maybe insert a limiter before the reverb.

Feature request: If you ever get a chance to add a pitch shifter in a feedback loop to the reverb with variable attenuation and pitch (Shimmer), that would be cool.

[Toltekradiation]

i did improve the reverb headroom with different kind of hp&lp filters, same as made by Valley audio, i think it's ok now (attached file).
@matrix12x, sorry for the feature request, i think i will let it as it is, my attempt for shimmer effect was not very convicing.
But if you wish, don't hesitate to set a reverb preset while all parameters are there, i would add yours to the list.

Last step is to allow saving the reverb parameters in the mixer file format, but i have troubles making it work...

[Xavier]

Thanks for the reverb work !
I'll have a look on friday (day off ).

[Toltekradiation]

Thank you Xavier.

There is a problem with code structure : the FxBus class is not in the right place, there is some refactoring to be done...

[Toltekradiation]

here is a version with complete reverb parameters, for preset design ( sorry for that, there were 3 missing parameters ) + reverb main level adjustment.

[Xavier]

Thanks
Is the latest version available from your git repo ?

[Toltekradiation]

i did not sync my repo:  it's now done

[Xavier]

Thanks a lot !!
I played with the reverb today and that's really awesome to be able to have a reverb inside the preenfm3.
Congrats and thanks for the hard work 

I worked on your modification with the idea to integrate it in the firmware.
The branch is here, and you can have a look at the latest commit to see the difference with your repo.
https://github.com/Ixox/preenfm3/commits/FXGlobalFX-PVig

I hope you won't be disapointed but for the moment, i only kept the preset in the global param.
I added a volume and an output slection.
These 3 values as well as the send for each instrument are saved with the Mixer on the SD card.

[Xavier]

I changed my mind a little.

I plan to have an option in MENU>CONFIG : "Reverb param".
If set to "All", all params will show up in the global settings.

And i will save all params with the mixer and not the preset.

[Toltekradiation]

hello Xavier,
many thanks for the code integration
your additions are very useful !

But, yes, i agree that linking all reverb parameters to the mixer does make sense.

cheers !
 

[Xavier]

I had some time today and there's now an option to show all params :
  MENU>Config>Reverb params : Show or Hide.
Default value is Hide.

So out of the box, you only see the reverb preset.
But all params are available for users who wants that, after modifying the config.

My commit is here :
https://github.com/Ixox/preenfm3/commits/FXGlobalFX-PVig

Let me know if you see anything strange.

Thanks 

[Toltekradiation]

The hide/show solution is a great idea but some troubles so far :
well, no luck, the reverb do not produce any sound on my pmf3, i could not spot the problem so far .

About the preset param, i think it may be confusing for users :
one may not understand that changing preset will change some, not all, parameters of page 2 & 3 (if in display all mode).

I would separate clearly the two modes : no preset choosing in user mode.

If you wish to go this way i can redefine the presets, with all parameters.

[Xavier]

Yes there's a sound problem with the current version !!! 
What did i change at the last minute ?? Will try to find out.


When changing the preset, i apply all default values before the preset specific param.
So all params are reset if they were all changed.

[Xavier]

I pushed a fix.
I moved where the fxBus.init() is called, it works better