Author Topic: Question about the UI on the oscillator ADSR pages  (Read 446 times)

hitachii

  • Team member
  • *
  • Posts: 17
    • View Profile
Question about the UI on the oscillator ADSR pages
« on: March 23, 2022, 04:20:22 AM »
Hello!

I have a question regarding the UI and possibly making a modification in my firmware.

I would like to rearrange the  "osc(n) env a" and "osc(n) env b" pages in the menu so that Attack, Decay, Sustain, and Release are all on the page "env a" and the respective "lv" parameters are on "env b". Ideally, it would be consistent across all oscillators so that all "env a" and "env b" look like I've described.

If possible, I can attempt to do it on my own, but may come across additional questions. Where in the source code can I find these parameters in order to switch them around?

Thank you!

Xavier

  • Administrator
  • Hero Member
  • *
  • Posts: 2123
    • View Profile
Re: Question about the UI on the oscillator ADSR pages
« Reply #1 on: March 27, 2022, 06:23:31 PM »

Hi,

It's different on the preenfm2 and on the preenfm3.
On the preenfm2 you need to modify both engine and UI as they're need to fit.
The preenfm3 has a more independent UI.

I assume you talk about preenfm2 ?

Then the UI needs to be modified here :
https://github.com/Ixox/preenfm2/blob/master/src/synth/SynthState.cpp#L433

And the engine params here :
https://github.com/Ixox/preenfm2/blob/master/src/synth/Common.h#L309

FYI, this is where the 6 envs are defined, but i think you don't have to modify this :
https://github.com/Ixox/preenfm2/blob/master/src/synth/Common.h#L416

That will break Midi compatibility.
So it won't work anymore with the editor.