Author Topic: midi cc not working on preenfm3?  (Read 2799 times)

sisyphus

  • Team member
  • *
  • Posts: 12
    • View Profile
midi cc not working on preenfm3?
« on: November 06, 2022, 06:09:21 AM »
trying to control midi cc on preenfm3 with cirklon. For example CC# 41 / 42 aren't affecting anything. is there a secret handshake to enable this?

Xavier

  • Administrator
  • Hero Member
  • *
  • Posts: 2257
    • View Profile
Re: midi cc not working on preenfm3?
« Reply #1 on: November 06, 2022, 11:20:57 AM »

Hi,
What do you expect from CC# 41 and 42 ?
They don't do anything.

Midi CC are the same as for the preenfm2.
See right column here :
https://ixox.fr/preenfm2/preenfm/midi/


Toltekradiation

  • Sr. Member
  • ****
  • Posts: 254
    • View Profile
Re: midi cc not working on preenfm3?
« Reply #2 on: November 06, 2022, 11:45:19 AM »
Hello,
i think it's about reverb param, as written here :
https://github.com/Ixox/preenfm3/blob/master/firmware/Src/midi/MidiDecoder.h#L67

yes, the midi cc handling for those params is missing.
I can prepare a PR for this, if needed.

Toltekradiation

  • Sr. Member
  • ****
  • Posts: 254
    • View Profile
Re: midi cc not working on preenfm3?
« Reply #3 on: November 06, 2022, 12:26:57 PM »

Xavier

  • Administrator
  • Hero Member
  • *
  • Posts: 2257
    • View Profile
Re: midi cc not working on preenfm3?
« Reply #4 on: November 06, 2022, 02:13:44 PM »

I saw i deleted this part in an "integration" commit some time ago.
I think that was because there are math processing that must be done in FXBus.paramChanged() when a param is changed.
And the midi direct change does not call this function.

Not sure we want to allow continuous midi CC that triggers paramChanged() on every change.

Toltekradiation

  • Sr. Member
  • ****
  • Posts: 254
    • View Profile
Re: midi cc not working on preenfm3?
« Reply #5 on: November 06, 2022, 06:30:56 PM »
ok, you're right, it would be quite cpu hungry to deal with it like that, so i added some slowndown in the CC handling mecanism :
It would now recalculate changes once in 100 blocks.
Reverb params should not be realtime handled by CC anyway, it may be usefull to change once when loading songs or scene changing.

new PR here https://github.com/Ixox/preenfm3/pull/32

Toltekradiation

  • Sr. Member
  • ****
  • Posts: 254
    • View Profile
Re: midi cc not working on preenfm3?
« Reply #6 on: November 07, 2022, 07:15:56 PM »
Another possibility is to drop off completly midi CC for reverb params and let people manage various reverb configuration with mixer files instead.
Which seems to be a good enough solution as you can easily tweak all parameters on the preenfm.

@sisyphus, what do you think about this ?
« Last Edit: November 07, 2022, 09:42:07 PM by Toltekradiation »

sisyphus

  • Team member
  • *
  • Posts: 12
    • View Profile
Re: midi cc not working on preenfm3?
« Reply #7 on: November 08, 2022, 06:44:29 AM »
Doh! ahaha yea, I was looking at the LSB row for some reason.  Nice work! & thanks for the quik reply. works like a charm (:


Hi,
What do you expect from CC# 41 and 42 ?
They don't do anything.

Midi CC are the same as for the preenfm2.
See right column here :
https://ixox.fr/preenfm2/preenfm/midi/