Author Topic: Pfm2 : unison discussion  (Read 2439 times)

Xavier

  • Administrator
  • Hero Member
  • *
  • Posts: 1933
    • View Profile
Re: Pfm2 : unison discussion
« Reply #15 on: December 06, 2020, 06:59:38 PM »
Thanks for this discussion.
Unison is implemented in the pfm3 (v0.99)
I don't have time to port it back for the preenfm2 in the short term in  but it's on my list.




« Last Edit: December 06, 2020, 09:25:40 PM by Xavier »

Toltekradiation

  • Team Member
  • ***
  • Posts: 111
    • View Profile
Re: Pfm2 : unison discussion
« Reply #16 on: December 06, 2020, 07:16:19 PM »
that's great, many thanks Xavier !
i can't wait to check it out (..but my pfm3 is still to built  ::)).

matrix12x

  • Team Member
  • ***
  • Posts: 125
    • View Profile
Re: Pfm2 : unison discussion
« Reply #17 on: December 06, 2020, 09:10:28 PM »

Thanks for this discussion.
Unison i implemented in pfm3.
I don't have time to port it back for the preenfm2 in the short term in  but it's on my list.

Thanks! :-)
I saw that you implemented it in PFM3. Looking forward to it's implementation in the PreenFM2.

solipsvs

  • Team Member
  • ***
  • Posts: 199
    • View Profile
Re: Pfm2 : unison discussion
« Reply #18 on: January 04, 2021, 10:22:59 PM »
xavier just wondering if you found the time to copy and paste the code over from pfm3

Xavier

  • Administrator
  • Hero Member
  • *
  • Posts: 1933
    • View Profile
Re: Pfm2 : unison discussion
« Reply #19 on: January 05, 2021, 08:43:06 AM »
xavier just wondering if you found the time to copy and paste the code over from pfm3

Unfortunately it's not just copy and paste (UI page with parameter saved and midi controllable has to be added and is different).
And unfortunately my free time is very limited and always lots of things to do.
If someone wants to give a try, i can guide...
« Last Edit: January 05, 2021, 09:19:15 AM by Xavier »

lokki

  • Sr. Member
  • ****
  • Posts: 329
    • View Profile
Re: Pfm2 : unison discussion
« Reply #20 on: January 13, 2021, 08:34:11 PM »
i don't think your criticism is at the right place here. xavier is a single person doing this! no reason to be so "hateful"...

btw. there are many synth companies that sell synths that are no longer actively maintained, even if there are bugs in the firmware...xavier always had open ears to such reports and tried to fix those.

 nice to hear that you found your synth, happy patching with the virus!


matrix12x

  • Team Member
  • ***
  • Posts: 125
    • View Profile
Re: Pfm2 : unison discussion
« Reply #21 on: January 14, 2021, 04:17:04 PM »
I agree with Lokki.

Also, the code is available for anyone to try to implement themselves if they are in a rush.


matrix12x

  • Team Member
  • ***
  • Posts: 125
    • View Profile
Re: Pfm2 : unison discussion
« Reply #22 on: February 13, 2021, 09:00:27 PM »
@Xavier,
I'm up for trying to add Unison to PFM2. Which file(s) for the PFM3 should I start looking at to see how its implemented?

xavier just wondering if you found the time to copy and paste the code over from pfm3

Unfortunately it's not just copy and paste (UI page with parameter saved and midi controllable has to be added and is different).
And unfortunately my free time is very limited and always lots of things to do.
If someone wants to give a try, i can guide...

Xavier

  • Administrator
  • Hero Member
  • *
  • Posts: 1933
    • View Profile
Re: Pfm2 : unison discussion
« Reply #23 on: February 13, 2021, 10:04:27 PM »
OK i have a little time to spend on that too.
The preenfm3 does not have any critical bugs and the editor does what i wanted it to do.

The 2 pfm3 commits are (hope i don't forget anything):
https://github.com/Ixox/preenfm3/commit/366b72ffdf8a21360d2276f7effbe1200f5ef8d8
https://github.com/Ixox/preenfm3/commit/4757eefde1121c9c3bf9a5cf840071ca1487fc7e

Not sure the second one is relevant for the pfm2 and the first on contains many variables refactoring that has nothing to do.
Look at Common, timbre, synthstate,voices classes.

What will be more complicated is to integrate the new parameters in the UI of the pfm2.
What i have in mind is to add a second Engine page after
Algo / Velo / voice / glide

Which would be enabled only if voice is >=2
Mode (poly or unison) / spread / detune

My biggest concern is that i'd like it to be compatible with the preenfm3 and the editor.




matrix12x

  • Team Member
  • ***
  • Posts: 125
    • View Profile
Re: Pfm2 : unison discussion
« Reply #24 on: February 13, 2021, 11:51:06 PM »
Thank you very much for the direction. It is appreciated.

This makes sense to add the unison page as the second Engine page and it seems to match what you did with your PFM 3 code.

I just started going through the PFM3 code in the commits and comparing to the latest PFM2 code on github. It looks like many of the functional changes for unison are in Timbre.cpp.


Xavier

  • Administrator
  • Hero Member
  • *
  • Posts: 1933
    • View Profile
Re: Pfm2 : unison discussion
« Reply #25 on: February 14, 2021, 09:11:01 AM »
You can have a look if you're interested.
But I'll likely include it myself in the next couple of weeks.
(2 weeks : I Don't have much time per day ;)  and i want to make sure i can include that easily in the editor a bit later)

Xavier

  • Administrator
  • Hero Member
  • *
  • Posts: 1933
    • View Profile
Re: Pfm2 : unison discussion
« Reply #26 on: February 15, 2021, 06:56:58 PM »

Or maybe sooner :)
I created a git branch Unison of my work in progress.
https://github.com/Ixox/preenfm2/tree/Unison


matrix12x

  • Team Member
  • ***
  • Posts: 125
    • View Profile
Re: Pfm2 : unison discussion
« Reply #27 on: February 16, 2021, 12:36:54 AM »
Wow you are fast.

I compiled it with no errors and flashed it.
 
However, I cannot seem to access the new Unison page. I may be missing something. My understanding is that I would press ENG and the Unison page would be the second Engine page.
After the first Engine page it goes straight to the Modulation page.

matrix12x

  • Team Member
  • ***
  • Posts: 125
    • View Profile
Re: Pfm2 : unison discussion
« Reply #28 on: February 16, 2021, 12:39:28 AM »
My error. I just looked through your code and found it.

Edit: I think I found a bug. The Unison menu does not seem to appear if voices is set to 1 only if Voice is set to 2 or higher.
Edit again: oh, now that I've played it for a few hours this makes sense because if Voice is only set to 1, what is there to detune. So never mind. It's not a bug.

Also, if I have voice set to 1 and press MOD enough times the Unison screen shows as well. But does not function (because voice is 1). That is changes to Spread and Detune don't change the sound.

If I go back to change Voices to anything greater than 1, then Spread and Detune do correctly change the sound.

Ok, so if I change Voices to any number over 1, "Glide" no longer disappears if unison is on. EDIT: ahh I think this makes sense since unison is monophonic.

BTW unison sounds AMAZING!! I started making some sick sounding pads.
« Last Edit: February 16, 2021, 05:25:47 AM by matrix12x »

vurt

  • Team Member
  • **
  • Posts: 77
    • View Profile
Re: Pfm2 : unison discussion
« Reply #29 on: February 16, 2021, 08:12:16 AM »
Unison is something i've really wanted for preenfm2  ;D