[available in v1.08] global fx attempt : REVERB

[Toltekradiation]

the previous fl-201 implementation has been melt into the new one.
there is only one left.
It remains in the envelope section though

i updated the readme for the knob overview :
https://github.com/pvig/preenfm3

[Toltekradiation]

here is a version with the output level of the reverb a bit lower, as it could clip sometimes..
There is also different interpolation in this one : i could finaly find the allpass interpolation formula in the part2 of the Dattoro paper !
https://ccrma.stanford.edu/~dattorro/EffectDesignPart2.pdf

it sounds smoother when modulation is applied.

[Toltekradiation]

@Xavier, you were right,  there were a nasty bug in one of the allpass filters which did distord in an ugly way
sorry for that, i had some serious earing fatigue 

fortunately, it's fixed now :
the reverbaration is much clearer and sound quite close to the vst
the decay is also much longer.

[Xavier]

@Xavier, you were right,  there were a nasty bug in one of the allpass filters which did distord in an ugly way
sorry for that, i had some serious earing fatigue 

fortunately, it's fixed now :
the reverbaration is much clearer and sound quite close to the vst
the decay is also much longer.

Wow... now that sounds GOOD ! very very good !!!
That really adds something great to the preenfm3.

I really don't know how you did that, i have to look at the code !
Not sure I understand all the 12 tweakable params 

[Toltekradiation]

  happy to hear you like it too !

the Dattoro Reverb blocks are :

input > lp & hp > pre delay > input diffuser > reverb tank ( (allpass>delay>lp>allpass>delay) > (allpass>delay>allpass>delay) ) > output from various point in the tank


Global page 3 : Master Fx 1

    Pre delay : Time of pre delay
    Pre delay Mix : the input diffuser is fed with a mix of audio input and the pre delayed input.
    Diffusion : set the input & tank diffuser allpass coefficient
    Decay : tank feedback
    Size : size of the tank delay
    Damping : cut off of the tank lowpass

Global page 4 : Master Fx 2

    Mod Speed : lfo speed (4 of them)
    Mod Depth : lfo mod depth, modulate the 4 delay allpass in the tank
    Env Mod : envelope mod depth, make the tail pitch shifting up or down
    Threshold : audio level at which envelope trigger
    Input Tilt : input filter from lowpass ~0 to high pass ~1
    Env Feedback : feedback (decay) modulation with the envelope

the envelope release rate is relative to the decay param.

About the envelope, there is an annoying glitch while in the envelope attack phase, i will try to find a workaround for it..

[matrix12x]

Very excited about this reverb.

[Xavier]

Too bad i don't have time to take a deep look in the next weeks.

I would really like to include it in the firmware, but may be with less parameters, maybe one page.
Would be great also that it does not use CPU if all signals are 100% dry.
That's my plan for when i have time

[matrix12x]

That would be awesome!

[Toltekradiation]

hello,
ok, i will try my best to keep only 6 parameters.
Maybe with some kind of presets or something.

[Toltekradiation]

Here it is !

- Most of the bugs are gone (should be)
- Auto bypass of most of the reverb code when there is no send set and the reverb tail is over (if any).

- One parameter page :
* Preset select
* Input Tilt
* Pre delay
* Pre delay Mix
* Mod Speed
* Mod Depth

For now there is still a second page to handle the preset parameters if one want to make new preset.
        * Size
        * Diffusion
        * Damping
        * Decay

The current list of preset go from extra small to extra large volumes, each in dark, warm and bright version, and then some more..

[matrix12x]

Dude, this is amazing work!! You never fail to impress.

[Toltekradiation]

  Thanks!

[matrix12x]

@Toltekradiation I noticed on boot, if I go to the 4th screen for Global (Master fx 2) that items 5 and 6 in the list show a 214748 (instead of a text label like decay or something) with a value of 214748. However, if I turn knob 5 or 6 and cycle thru the Global pages, the text next to 5 and 6 on Master fx 2 go blank and the value shows a normal number (between -1 to +1).

I think that some variables for sets 5 and 6 in the Master fx 2 are not initialized with a zero ro something on startup. Note, it does not seem to affect the sound when its weird. The reverb sounds normal.

[Toltekradiation]

it does not matter anymore : i added two more parameters on the Master fx 2 page 

this page is not supposed to live forever anyway : it's only to allow making presets easier.

Here is another .bin with a different set of parameters for the presets, the main parameters (Master fx 1 page) now are :

Preset
        Group of parameters :
            Size
            Lfo speed
            Lfo Depth
            Decay
            Diffusion
            Notch Base
            Damping
    Pre delay
        Time of pre delay
    Pre delay Mix
        the input diffuser is fed with a mix of audio input and pre delayed input.
    Filter Base
        Input filter hp/lp
    Filter Width
    Notch Spread
        Input is filtered with a 4 pole allpass filter

I hope it's a more useful combination

[matrix12x]

cool. Just installed and played with it a little and it seems to work well.